Localize SuperSplat to Chinese, Japanese and Korean #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If any Japanese speakers can check the translations, I would really appreciate it! I used Copilot to generate them. |
willeastcott
changed the title
willeastcott
changed the title
Co-authored-by: Will Eastcott <[email protected]>
|
Hello! I've submitted a Pull Request to review and fix the Japanese translation. |
|
Thanks, @yushimatenjin - this is now deployed. Can you please go here and verify that the UI is automatically set to Japanese for you? |
|
@willeastcott
|
|
That's excellent. Thanks for confirming! |
|
Hey @nmgyaoyuan, are the Chinese translations OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use i18next to localize SuperSplat. Initially, Chinese, Japanese and Korean have been added as the first non-English languages:
Chinese:
Japanese:
Korean:
Note: the localization should autoselect based on the browser's locale. However, you can force it with the
lngquery parameter (i.e.https://playcanvas.com/supersplat/editor?lng=ko).We could potentially externalize the strings in future, but for now, it's quite convenient to have them in the code.